Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when sorting results, make the default secondary column sort 'nb_visits' #7401

Closed
mattab opened this issue Mar 10, 2015 · 2 comments
Closed

when sorting results, make the default secondary column sort 'nb_visits' #7401

mattab opened this issue Mar 10, 2015 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
3.0.0-b1

Comments

@mattab
Copy link
Member

mattab commented Mar 10, 2015

The goal of this issue is that when a column is sorted in any report, and when two values are identical for this column, then the result will be sorted by a secondary column. Each report could decide which secondary column to sort by, but the default will be nb_visits.

The current behavior is not ideal as the rows appear to be sorted randomly eg. when all values of the sorted column are 0. Example screenshot
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Mar 10, 2015
@mattab mattab added this to the Piwik 2.12.0 milestone Mar 10, 2015
@mattab mattab mentioned this issue Mar 10, 2015
Merged
@diosmosis
Copy link
Member

I think this is done by default when the data type is numeric. I might be remembering incorrectly, but for strings it doesn't do this, which caused problems for me during the processed metrics refactor.

tsteur added a commit that referenced this issue Mar 12, 2015
@tsteur
Made sort much faster by using builtin php methods.
ce322af 
As I side effect I fixed many bugs that were in the previous
sort filter implementation. The code is better tested now and
it does now use a secondary column on nb_visits or label if possible
see #7401
@tsteur tsteur mentioned this issue Mar 13, 2015
Closed
@mattab mattab modified the milestones: Piwik 3.0.0, Piwik 2.12.0 Mar 13, 2015
@tsteur tsteur mentioned this issue Mar 17, 2015
Merged
@tsteur tsteur mentioned this issue Jul 28, 2015
Merged
@mattab
Copy link
Member Author

mattab commented Aug 13, 2015

Should be fixed with #8449

@tsteur tsteur closed this as completed Aug 18, 2015
@mattab mattab modified the milestones: 3.0.0, 3.0.0-b1 Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
3.0.0-b1
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab