Live.getCounters times out on very large instance #7399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $idSite, | ||
| $lastMinutes, | ||
| $segment, | ||
| 'COUNT(log_visit.visit_last_action_time)', |
There was a problem hiding this comment.
When using count(*) and passing a segment eg pageUrl this method fails. It took me a long time to figure out what is going on. Anyway, we do not get an error when passing a log_visit field here and I made sure count(log_visit.visit_last_action_time) is as fast as count(*) as it still can do everything on the index and doesn't have to query the table.
tsteur
added
not-in-changelog
* If we know there are 0 visits, do not execute any further query. * Added showColumns as it is more appropriate
tsteur
added
Needs Review
|
Looks good to me! 👍 |
mattab
pushed a commit
that referenced
this pull request
Mar 11, 2015
Live.getCounters times out on very large instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6758
We do only display the number of visits and actions in the Real time widget so let's only request those. This should make it very fast as we can avoid the
visitorscounter which is slow. Eg the visitors counter takes a few seconds on many million rows whereas thevisitscounter standalone takes maybe0.05seconds if at all. If someone uses the API it will be still "slow" on a very large instance.Adding a separate query for
visitsandvisitorsshouldn't make a huge difference as thevisitorsone is so slow compared to thevisitsone.In the actual "Live counter" widget we do only request the last 3 minutes were we shouldn't have any problem with the unique visitors counter as MYSQL will choose a different index automatically.
I added another tweak: If
visitsis0we can assume that all other counters are0as well so we do not execute any further query at all. We can assume this as we request thelast_action_timeso we should be sure there was no further action etc.