Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend command 'development:sync-ui-test-screenshots' to sync UI screenshots of Plugins #7393

Closed
mattab opened this issue Mar 9, 2015 · 0 comments
Closed

extend command 'development:sync-ui-test-screenshots' to sync UI screenshots of Plugins #7393

mattab opened this issue Mar 9, 2015 · 0 comments
Assignees
@mattab
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.12.0

Comments

@mattab
Copy link
Member

mattab commented Mar 9, 2015 •
edited

The goal of this issue is to improve the command development:sync-ui-test-screenshots so that it lets us synchronise screenshots of Plugins as well as core.

This will be very useful for our Green Builds Monday effort #6544 where after changing the OmniFixture we see many UI tests failing simply because of data changes.

Currently it only lets us sync the core screenshots. We would like to do something like: ./console development:sync-ui-test-screenshots --plugin WhiteLabel --user=username --password=password. the username and password are needed for Premium plugins where the artifacts are password protected. This command would automatically copy the screenhots from http://builds-artifacts.piwik.org/protected/ui-tests.master.WhiteLabel/$build-number into the plugin directory plugins/WhiteLabel/tests/UI/expected-ui-screenshots/ similarly to how it's done for core UI screenhots currently.

Steps

  • Add new options to the console
  • Test it on an open source plugin
  • Test it on a premium plugin eg. WhiteLabel
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Mar 9, 2015
@mattab mattab added this to the Piwik 2.12.0 milestone Mar 9, 2015
@mattab mattab self-assigned this Mar 12, 2015
mattab added a commit that referenced this issue Mar 12, 2015
@mattab
Add support for HTTP AUTH requests in the HTTP client, only for CURL …
845cb20 
…refs #7393
mattab added a commit that referenced this issue Mar 12, 2015
@mattab
Ability to sync UI screenshots for Plugins including premium plugins
10dc7d3 
fixes #7393
updated wiki at: https://github.com/PiwikPRO/support/wiki/How-to-develop-PRO-plugins%3F
This was referenced Mar 12, 2015
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
1 participant
@mattab