Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When UserID is set to empty string, actions maybe added to the same UserID visit #7368

Closed
Glisse1 opened this issue Mar 5, 2015 · 7 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@Glisse1
Copy link

Glisse1 commented Mar 5, 2015

Hello, I have this strange bug since upgrading to the latest point release: when opening a visitor profile it lists ALL visits and visitors (i believe from that day or so) instead of only the correct visits for each one.. also, when opening a visitor profile from say 5 hours ago, still shows even the latest visits of other visitors, occurred long after that one...when clicking individual visit #1, visit #2, etc the correct information appears with different ip, browser, screen resolution, etc... so it does distinguish between visits.. its just that they are all crammed together.

@Glisse1
Copy link
Author

Glisse1 commented Mar 5, 2015

It has gotten worse.. all of my visitors are now under the same visitID.
Symptom:

  • a user joins my site, visitID let`s say No longer refreshes automatically in pinned tabs #14611 is created. They browse several pages and leaves;
  • later on completely another user joins my site, sees other pages.. but the session No longer refreshes automatically in pinned tabs #14611 is continued from where it ended;
  • and so on.
  • to be sure i created myself several incognito visits in both chrome and firefox, both direct and via google search, which always were separated visitsID.. i know because i do that often to check things.. but now all of them continued that initial session.
  • tried to clear the temp folder, did nothing to help :(

I now have a 4 hours long session with pageviews from at least 10 different unique visitors, from all over the country.. i can see them joining in google analytic real-time map... actually some of them are not registered at all in piwik, although they are actively browsing the site and viewing different pages according to GA (so are not bots)

A new session is created if a new user is on mobile tho.

All of these started last night when i updated to the latest point release 2.11.2

@quba
Copy link
Contributor

quba commented Mar 5, 2015

Are you using standard Piwik tracking code or also some additional features?

@Glisse1
Copy link
Author

Glisse1 commented Mar 5, 2015

only userID is added via wordpress users login credentials, which worked perfectly until last night.. my tracking code in theme header:

var _paq = _paq || [];
_paq.push(['setUserId', 'user_login ;?>']);
_paq.push(['trackVisibleContentImpressions', true, 750]);
_paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);

(function() {
var u="xxxxxx";
_paq.push(['setTrackerUrl', u+'piwik.php']);
_paq.push(['setSiteId', 1]);
var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
g.type='text/javascript'; g.async=true; g.defer=true; g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
})();

@quba
Copy link
Contributor

quba commented Mar 5, 2015

I would say that it's connected with userId. Please make sure that you are passing there different userid for different users. If that's the case, then it's possible that we have here another bug.

Please also make sure that you don't set userid for anonymous users.

@Glisse1
Copy link
Author

Glisse1 commented Mar 5, 2015

My tracking code is unchanged for several months.. so there is nothing different on my end.. the thing is that most of the times (80 % of cases or so) there is no userID passed so it cant be different..that`s because the user is not logged-in, no username/email/etc to pass.. only when a user logs-in the userID is set and is recognized as such.. this is how it used to be, and if i recall correctly this is how it was meant to work.. if there is is a userID very good, it helps tracking the same user across different devices, if not, no problem, the old mechanism still works.

will investigate and remove userID and will follow-ip

@Glisse1
Copy link
Author

Glisse1 commented Mar 5, 2015

Removed the userID from the tracking code and the bug is gone.. both the userprofile one, and the later..
So, this means that this feature is no longer available? It worked fine for several months..

@Glisse1 Glisse1 changed the title Visitor profile bug: all visits are assigned to a single visitor Visitor profile bug (due to userID): all visits are assigned to a single visitor Mar 5, 2015
@mattab mattab self-assigned this Mar 6, 2015
@mattab mattab added this to the Piwik 2.12.0 milestone Mar 6, 2015
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 6, 2015
@mattab mattab changed the title Visitor profile bug (due to userID): all visits are assigned to a single visitor When UserID is set to empty string, actions maybe added to the same UserID visit Mar 10, 2015
mattab added a commit that referenced this issue Mar 10, 2015
…would set the same visitor id to all those visitors
@mattab
Copy link
Member

mattab commented Mar 10, 2015

Hi guys, I found the issue. Indeed there is a regression when the User ID is set to empty string. Before it wouldn't update the Visitor ID, but now it does. I've fixed it in this PR: #7402

@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants