@mnapoli opened this Pull Request on March 5th 2015 Contributor

Fixes #7087

After creating a website (whether it is after the installation or after adding a new website to an existing install), you will see this page as long as no visits are recorded:

capture d ecran 2015-03-09 a 10 44 54

@mnapoli commented on March 6th 2015 Contributor
@mattab commented on March 6th 2015 Member

quick note regarding the look and feel: can you make the H2 look like the admin H2:

h1

and H3 look like admin H3:

h2

Btw maybe somehow it's related to inconsistency in https://github.com/PiwikPRO/plugin-CloudAdmin/issues/44 (not sure if that's correct though)

@mnapoli commented on March 8th 2015 Contributor

Done, screenshot updated in the description.

@mattab commented on March 9th 2015 Member

Nice improvement... here is feedback

  • add link on the final sentence %1$sTracking Code%2$s to link to the Tracking code page in admin (which offers more option and may be useful to some)
  • "No data is recorded yet" -> "No data has been recorded yet"
  • maybe we can split the translation string SiteWithoutDataHelp into two strings, in case we could reuse one of them later or changing only one of them would be slightly easier for translators.
  • could we add a UI test for this page, to ensure this onboarding improvement won't regress later on?
@mnapoli commented on March 9th 2015 Contributor

Changes implemented. I've added a test too (3 hours for a simple UI test :'( )

For the record master is broken so the pr is failing

@mattab commented on March 9th 2015 Member

On the screenshot it seems the H3 looks blue rather than black in the admin?
Btw I'm wondering, would the correct fix be to remove the H2/H3 style that was added and then it should default to the "standard piwik titles" which should look good by default (if they don't look good, can we fix the default h2/h3 so they look good in all future custom pages) ?

@mattab commented on March 9th 2015 Member

Changes implemented. I've added a test too (3 hours for a simple UI test :'( )

Nice, the UI test is very useful.

Wow, 3 hours is a long time. Was the painful part to have to manually load the plugin? This seems like it should not be needed, I've asked Benaka in the comment. Otherwise, do you have suggestions to make this better for other devs in the future?

@mnapoli commented on March 9th 2015 Contributor

The painful part was running the tests at all. I've messed up several things on my own machine by setting up piwik so I don't want to try to run the ui test locally. The vagrant setup isn't good because it checks out an entire new copy of Piwik, so I had to resort using the AWS tests runner but had to fix it and improve it first. And then a big problem was understanding how fixtures work and how I can add new fixtures/site. I've given up on that and found the siteId 4 was empty, I hope it will stay that way. The developer documentation on all that is not helpful.

Regarding fixing the titles, I don't really want to refactor the CSS in that PR, I'm already working on that separately. I can fix the blue color.

@diosmosis commented on March 10th 2015 Member

FYI if you want to ensure the site is always empty, you can do this.fixture = 'Piwik\Tests\Framework\Fixture' in the UI test. I don't think the ui tests are significantly documented anywhere; I can add something on developer.piwik.org if there's nothing there already.

@mattab commented on March 10th 2015 Member

actually UI tests are already documented in the readme: https://github.com/piwik/piwik/blob/master/tests/README.screenshots.md and in the developer site: http://developer.piwik.org/guides/tests-ui

I was asking what was the pain point to see if we could improve those resources...

@mnapoli commented on March 10th 2015 Contributor

@mattab there is no documentation about fixtures though

@mattab commented on March 10th 2015 Member

so the missing doc was Fixtures? that's a good point... do you mind create an issue in developer-documentation so we don't forget about this missing doc? it'd be nice to prevent other devs in the future from feeling this frustration :+1:

@mattab commented on March 12th 2015 Member

Looks good to me, very nice change! this should make a big difference to user onboarding and help minimise a lot of frustrations for new users.

@RMastop commented on March 21st 2015 Contributor

There might be an issue with sites not having visitors every day. I updated a demo site to the latest beta build and instead of showing the dashboard, Piwik showed the tracking script.
After I used the visitor generator, the dashboard shows me the historic data and the just created data.

@mnapoli commented on March 21st 2015 Contributor

@RMastop are you clearing the log_visit table? Because the query is dead simple it should pick up previous visits: SELECT idsite FROM log_visit WHERE idsite = ? limit 1

@RMastop commented on March 21st 2015 Contributor

@mnapoli that's it, I cleared logs and had only archived data on my instance. What are the ods that this happens in real live? Probably none.

@mattab commented on March 21st 2015 Member

Good point, actually this could happen for many users, eg. if you setup the "Delete old logs" feature which deletes old logs.

@mnapoli I think we should follow up before 2.12.0 and put some kind of safety net: maybe we disable this screen if the "delete old logs" feature is enabled?

@mnapoli commented on March 21st 2015 Contributor

@mattab Yes indeed, but that is in the case where the entirety of log_visit is deleted for a site, is that a common scenario?

Anyway:

maybe we disable this screen if the "delete old logs" feature is enabled?

That makes sense, will do on monday first thing.

@mnapoli commented on March 22nd 2015 Contributor

@mattab I fixed it in 2aed127e94ae55 and tested locally

This Pull Request was closed on March 12th 2015
Powered by GitHub Issue Mirror