Fix Recursive DataTableFilter behaviour #7362
Labels
Bug
For errors / faults / flaws / inconsistencies etc.
c: Performance
For when we could improve the performance / speed of Matomo.
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone
On a dataTable it is possible to
enableRecursiveFilter()
. Expected behaviour is that, if enabled, it would actually run ALL filters recursive. This is not the case.Currently, it is up to each DataTable filter whether it handles recursive or not. Some call
$this->filterSubtables()
on each row within a filter so it respects theenableRecursiveFilter
setting and runs recursive. Some to always run recursive and not respect this setting, some do not run recursive at all (never).The proper fix is to handle the recursion in the
filter
andqueueFilter
method of the DataTable. A filter itself should not have to take care of this. This will make sure that it will always work, even on closures.The text was updated successfully, but these errors were encountered: