Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Recursive DataTableFilter behaviour #7362

Open
tsteur opened this issue Mar 4, 2015 · 0 comments
Open

Fix Recursive DataTableFilter behaviour #7362

tsteur opened this issue Mar 4, 2015 · 0 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.

Comments

@tsteur
Copy link
Member

tsteur commented Mar 4, 2015

On a dataTable it is possible to enableRecursiveFilter(). Expected behaviour is that, if enabled, it would actually run ALL filters recursive. This is not the case.

Currently, it is up to each DataTable filter whether it handles recursive or not. Some call $this->filterSubtables() on each row within a filter so it respects the enableRecursiveFilter setting and runs recursive. Some to always run recursive and not respect this setting, some do not run recursive at all (never).

The proper fix is to handle the recursion in the filter and queueFilter method of the DataTable. A filter itself should not have to take care of this. This will make sure that it will always work, even on closures.

@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Mar 4, 2015
@tsteur tsteur added this to the Piwik 3.0.0 milestone Mar 4, 2015
@mattab mattab modified the milestones: Mid term, 3.0.0 Aug 13, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

No branches or pull requests

2 participants