FrontController refactoring #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(adding |
|
No comments, merging |
mnapoli
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring: I have extracted code from the FrontController in order to simplify it.
I have followed Symfony's architecture by putting the code responsible to create the controllers in a ControllerResolver class. A controller is now a simple
callablein the front controller.Also that's minor but the report/widget classes where created 2-3 times, now there are created only once. I think in the future the
Widget::factory()/Report::factory()static methods could be moved to theControllerResolverso that widget and report classes are created by the container: that would allow to use dependency injection in them.(if you want to see the diff, I think seeing each commit diff separately is easier)