Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log import speedup #7360

Closed
wants to merge 3 commits into from
Closed

Conversation

medic123de
Copy link
Contributor

Cave!: includes fix for #6398

noticable speedup with 6 recorders ( 8 cpu ), max-payload=1000, run twice, took average:

original: Requests imported per second: ~600 requests per second

patched:
request-cache-size=6: ~620 requests per second
request-cache-size=12: ~700 requests per second
request-cache-size=30: ~830 requests per second

maximum with this machine seems to be around 950 - 1000 requests per second

raw values:
no cache:
/tmp/import_orig1: Requests imported per second: 607.05 requests per second
/tmp/import_orig2: Requests imported per second: 612.01 requests per second

cache=6
/tmp/import6_1: Requests imported per second: 646.4 requests per second
/tmp/import6_2: Requests imported per second: 606.66 requests per second

cache=12
/tmp/import12_1: Requests imported per second: 663.66 requests per second
/tmp/import12_2: Requests imported per second: 732.35 requests per second

cache=30:
/tmp/import30_1: Requests imported per second: 833.28 requests per second
/tmp/import30_2: Requests imported per second: 816.96 requests per second
/tmp/import_new: Requests imported per second: 841.25 requests per second

Try: max-payload=2000, cache=100, recorder=6
Requests imported per second: 767.68 requests per second

Try: max-payload=1000, recorder=(2*CPUs)=12
Requests imported per second: 977.24 requests per second
Requests imported per second: 927.23 requests per second

Andreas Faust and others added 3 commits March 3, 2015 23:41
sort by IP + Date
spread PHP load  more evenly by redefining "max_payload_size"
@diosmosis
Copy link
Member

This pull request breaks the ImportLogsTest PHP system test. This means your changes potentially break the accuracy of the log importer. The pull request can't be merged until the tests pass or there is an explanation for why the existing tests are incorrect.

@medic123de
Copy link
Contributor Author

Hi diosmosis,
than you for your explanation. I suspect there might eventually an issue in Piwik.
I don't see how any accuracy harm can be done within the importer ( which just bulks things together, and piwik itself does the "accurate tracking" itself ). Nevertheless, I close the pull request because of the included non-working fix, and will retest and re-request when I found what happens there.

Cheers
medic

@medic123de medic123de closed this Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants