Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer install fails for Piwik 2.10.0 #7353

Closed
mgazdzik opened this issue Mar 4, 2015 · 6 comments
Closed

Composer install fails for Piwik 2.10.0 #7353

mgazdzik opened this issue Mar 4, 2015 · 6 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@mgazdzik
Copy link
Contributor

mgazdzik commented Mar 4, 2015

Due to change in https://github.com/piwik/component-cache/ repository now Piwik 2.10.0 cannot be installed.
Repository listed here https://github.com/piwik/piwik/blob/2.10.0/composer.json#L92 does not exist any more and composer install command fails.
Composer install output for referrence:

Installing doctrine/cache (dev-filecache-race-condition-fix c5a6d2a)
Cloning c5a6d2ade84241128fcf95eca386e07b11ffa347

  [RuntimeException]                                                                       
  Failed to clone git@github.com:piwik/cache.git via git, https, ssh protocols, aborting.  
  - git://github.com/piwik/cache.git                                                       
    Cloning into '/private/var/www/piwik/master.piwik/vendor/doctrine/cache'...            
    fatal: remote error:                                                                   
      Repository not found.                                                                
  - https://github.com/piwik/cache.git                                                     
    Cloning into '/private/var/www/piwik/vendor/doctrine/cache'...            
    remote: Invalid username or password.                                                  
    fatal: Authentication failed for 'https://github.com/piwik/cache.git/'                 
  - git@github.com:piwik/cache.git                                                         
    Cloning into '/private/var/www/piwik/vendor/doctrine/cache'...            
    ERROR: Repository not found.                                                           
    fatal: Could not read from remote repository.                                          

    Please make sure you have the correct access rights                                    
    and the repository exists. ```
@mattab
Copy link
Member

mattab commented Mar 4, 2015

Explanation: we used to maintain the doctrine/cache fork until they merged our patches/fixes upstream in their own git repo. Then we deleted our fork as we thought it wasn't useful anymore.

Suggested solution: could you modify the doctrine/cache in composer.json/lock and point instead to their latest release like it is done in our current composer?

@mnapoli
Copy link
Contributor

mnapoli commented Mar 4, 2015

Try to require Piwik 2.11 instead it should solve your problem?

@mgazdzik
Copy link
Contributor Author

mgazdzik commented Mar 5, 2015

I believe that there are more drawbacks of this situation:

  • we cannot setup locally 2.10.0 instance
  • travis cannot run tests for this version (as it can't install Piwik)

Ability to setup any historical version is crucial for developers in matters of local debuging, investigations, plugin development, CI operation for older version, package building with composer, etc. Also not all instances can be updated to latest version over a day and it could be a serious problem I think.

I think that such situations shouldn't occur, as basically previous tags available on Git are useless without manual hacking in composer.json.
Having that said maybe for sake of old versions this fork could be restored and marked as deprecated or so, but builds would at least work?

@mnapoli
Copy link
Contributor

mnapoli commented Mar 5, 2015

@mgazdzik sorry didn't notice it was you :) I thought it was someone requiring Piwik in Composer because they wanted to use the reporting API classes 😉

I guess we could restore the fork but the branch is gone. We could maybe just use master and create the branch from it

@mnapoli
Copy link
Contributor

mnapoli commented Mar 5, 2015

I have recreated the fork with the branch taken from master: https://github.com/piwik/cache/tree/dev-filecache-race-condition-fix

Please let us know if it solves the problem.

@mgazdzik
Copy link
Contributor Author

@mnapoli - thanks for recreating missing part. I confirm that composer install passes in 2.10.0 👍

@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattab @mnapoli @mgazdzik