Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take DNT into account cf piwik/piwik#7317 #7352

Merged
merged 2 commits into from Mar 11, 2015
Merged

Conversation

ArnY
Copy link
Contributor

@ArnY ArnY commented Mar 4, 2015

If a DNT header was sent by the browser, the optout page should just tell the user he/she is not being tracked because of the way his/her browser's configured.

@mattab mattab added this to the Piwik 2.12.0 milestone Mar 6, 2015
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Privacy For issues that impact or improve the privacy. labels Mar 6, 2015
@mattab
Copy link
Member

mattab commented Mar 6, 2015

Hi @ArnY thanks for the PR!

@mattab mattab added the Needs Review PRs that need a code review label Mar 6, 2015
<noscript>
<button type="submit">{{ 'General_Save'|translate }}</button>
</noscript>
</form>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor thing but the indentation has been replaced by tabs in this file, whereas we use spaces. Could you please replace the indentation?

@mnapoli
Copy link
Contributor

mnapoli commented Mar 10, 2015

Except the tabs thing 👍

@ArnY
Copy link
Contributor Author

ArnY commented Mar 11, 2015

Done!

mattab pushed a commit that referenced this pull request Mar 11, 2015
@mattab mattab merged commit cdb6840 into matomo-org:master Mar 11, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 11, 2015
@mattab
Copy link
Member

mattab commented Mar 12, 2015

Thanks, it works (available in 2.12.0-b2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Privacy For issues that impact or improve the privacy. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants