Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running scheduled task with --force should run the tasks #7351

Closed
mattab opened this issue Mar 4, 2015 · 4 comments
Closed

Running scheduled task with --force should run the tasks #7351

mattab opened this issue Mar 4, 2015 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 4, 2015

From #7181 a user reported:

Just ran core:run-scheduled-tasks --force with the updated Rules.php file. This is the updated message:
Purging temporary archives: skipped (no authorization)

That's a bug. likely in Rules.isRequestAuthorizedToArchive ?

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 4, 2015
@mattab mattab added this to the Piwik 2.12.0 milestone Mar 4, 2015
@ThaDafinser
Copy link
Contributor

I also experienced the DB growth (thought it was because of another error first).

It seems that it catched the new message i introduced here (same for me currently) #7305

Is there a bug i dont see from my PR?

//Update i got it now shrinked again with the force parameter

@mnapoli
Copy link
Contributor

mnapoli commented Mar 4, 2015

Purging temporary archives: skipped (no authorization)

is shown if browser archiving is disabled and $_GET['trigger'] != 'archivephp'.

When running in the console $_GET['trigger'] is most probably empty, so if Piwik is using cron archiving you can't purge temporary archives…

Is that the intended behavior? Here is what the comment says:

we only delete archives if we are able to process them, otherwise, the browser might process reports when &segment= is specified (or custom date range) and would below, delete temporary archives that the browser is not able to process until next cron run (which could be more than 1 hour away)

@mnapoli
Copy link
Contributor

mnapoli commented Mar 4, 2015

Note the --force option just forces to run scheduled tasks (i.e. it applies only to the task scheduler).

Then each task has its own rules, I'm not sure it's easy to pass the concept of "--force" inside the actual logic.

@mattab mattab modified the milestones: Piwik 2.12.0, Piwik 2.13.0 Mar 11, 2015
@diosmosis
Copy link
Member

@mattab No longer relevant at least for archive purging since there is a dedicated command for it now. Since --force does force running scheduled tasks, I think this issue can be closed.

@mattab mattab closed this as completed Mar 22, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants