Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Right To Left languages in Piwik translations i18n effort #733

Closed
mattab opened this issue May 18, 2009 · 18 comments
Closed

Support Right To Left languages in Piwik translations i18n effort #733

mattab opened this issue May 18, 2009 · 18 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@mattab
Copy link
Member

mattab commented May 18, 2009

We are hoping for Piwik to be platform that every user can use in their own language. We support translations for all elements: calendar, graphs, reports, admin interface, etc.

Currently the support for right to left language hasn't be tested and used yet. We would need to contact an arab or hebrew translator, then define what issues to fix in the UI.

For example we may have to add conditional css style that will overload text classes/ids: direction: rtl, text-align: right (when original is left), add definition in translation file indicating what type of language we load (rtl,ltr).

@mattab
Copy link
Member Author

mattab commented Mar 29, 2010

Moving to post 1.0 until we find translators for RTL languages. If we do, we would definitely do it for 1.0!

@anonymous-matomo-user
Copy link

Attachment: Arabic Translation
ar.php

@anonymous-matomo-user
Copy link

Hi,

Just wanted to contribute the Arabic Translation for Piwik 1.0 it is not 100% but did my best to and hope to see it in the next patch/version with RTL support to ensure having more community contribution to reach the 100%

BR,
Mohamad Sibai

@robocoder
Copy link
Contributor

Potential blocker: http://bugs.jqueryui.com/ticket/5538

As a first step, we should define:

  • lang/en.php: 'General_LayoutDirection' => 'LTR', // or 'RTL'; "" or undefined is the same as 'LTR'
  • themes/default/common-rtl.css: add a stub file
  • when loading stylesheets (in templates or assetmanager), see if a basename-rtl.css file exists, and also include that

@anonymous-matomo-user
Copy link

#2074
how to change title and body to rtl for all blocks?

@robocoder
Copy link
Contributor

Note to self:

  • CSSJanus - flip css ftom left to right
    • MediaWiki has a php port of the above python code

@robocoder
Copy link
Contributor

Changing the language shouldn't require rebuilding the merged css asset or recompiling Smarty templates.

This appears to imply:

  • conditional loading of rtl css in the templates
  • a separate merged rtl css asset

@robocoder
Copy link
Contributor

Where the translation is incomplete, the layout is going to look messed up (defaults to the English text).

@mattab
Copy link
Member Author

mattab commented Feb 10, 2011

vipsoft, I thought the RTL CSS could work being conditionnaly loaded after all CSS, and overriding some values. So the merged CSS would stay the same, and there would be one more request for the RTL.css.

Where the translation is incomplete, the layout is going to look messed up (defaults to the English text).
what do you mean?

@anonymous-matomo-user
Copy link

When i am translate en.php to fa.php (farsi or persian) my theme not worked.

1 similar comment
@anonymous-matomo-user
Copy link

When i am translate en.php to fa.php (farsi or persian) my theme not worked.

@robocoder
Copy link
Contributor

(In [3867]) refs #733 - reviewing the styles embedded in .tpl files

@mattab
Copy link
Member Author

mattab commented Apr 13, 2011

(In [4431]) Refs #733

  • adding stub themes/default/rtl.css file loaded when the language is RTL (currently loaded for Arabic and Hebrew)
  • this stub file will be used to overwrite CSS properties to set text-align:right float:right etc. for all elements requiring to be aligned differently
  • Following screens use the RTL: Login, Admin screens, main dashboard reports, Update screen & Installation screens

@mattab
Copy link
Member Author

mattab commented Oct 1, 2012

Increasing priority: it would be nice to investigate having at least a basic rtl.css which would display the dashboard from right to left.

@mattab
Copy link
Member Author

mattab commented Feb 1, 2014

Consolidating milestones FTW

@shahar3012
Copy link

Hi,
My native language is Hebrew.
I'll add support for RTL languages in site theme (css).
If you have some major points I should look at in order to understand everything that need to be supported, I would appreciate it if you let me know.

Also, I'll try to add translation in Hebrew for all core plugins.

@sgiehl
Copy link
Member

sgiehl commented Feb 21, 2015

Regarding translations: Please register at http://translations.piwik.org to help improving the translations.

@mattab mattab modified the milestones: Mid term, Long term Dec 5, 2016
@mattab
Copy link
Member Author

mattab commented Dec 11, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@sgiehl sgiehl removed this from the For Prioritization milestone Jan 3, 2024
@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

6 participants