Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI builds on PHP 5.3.* instead of PHP 5.3.3 #7324

Closed
mattab opened this issue Mar 1, 2015 · 4 comments
Closed

Run CI builds on PHP 5.3.* instead of PHP 5.3.3 #7324

mattab opened this issue Mar 1, 2015 · 4 comments
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.11.2

Comments

@mattab
Copy link
Member

mattab commented Mar 1, 2015

The goal of this issue is to find a solution to the randomly failing CI builds on PHP 5.3.3.
Because we really do need our builds to be green at all times, we cannot afford failing builds due to bugs in PHP versions that are 5+ years old.

Note: this issue will be gone anyway when we deprecate PHP 5.3 in #7323
@mattab mattab added this to the Piwik 2.11.2 milestone Mar 1, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Mar 1, 2015
@mattab
Copy link
Member Author

mattab commented Mar 1, 2015

First commit in 14ede46

mattab added a commit that referenced this issue Mar 1, 2015
@mattab
Refs #7324 Ci builds run on PHP 5.3
59f21d0
@mattab
Copy link
Member Author

mattab commented Mar 1, 2015

Unfortunately that didn't solve the problem, build still failing hard: https://travis-ci.org/piwik/piwik/jobs/52668870

Looking forward to #7323 !

In the meantime, maybe we should mark the build as "Allow failures" and then we could check the PHP 5.3 build once a month prior to release, to make sure there are no new code added that only work for PHP 5.3... ?

mattab added a commit that referenced this issue Mar 2, 2015
@mattab
Allow PHP 5.3 build failures since they randomly fail so often, refs #…
d9bca90 
…7324

(cherry picked from commit 5bb23ee)
mattab added a commit that referenced this issue Mar 2, 2015
@mattab
PHP 5.3 build runs on PDO_MYSQL, refs #7324
a972fe5
@mattab
Copy link
Member Author

mattab commented Mar 2, 2015

Failures are now "allowed" for PHP 5.3 - problem solved https://travis-ci.org/piwik/piwik/builds/52689479

@mattab mattab closed this as completed Mar 2, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 2, 2015
mattab added a commit that referenced this issue Mar 2, 2015
@mattab
we decided to simply remove the 5.3 builds, since the UI tests run on…
b8403e7 
… 5.3 we would still catch most bugs Refs #7324
@mattab
Copy link
Member Author

mattab commented Mar 2, 2015

Another idea I just got, would be to run only unit + integration tests on PHP 5.3

mattab added a commit that referenced this issue Mar 8, 2015
@mattab
Running builds on PHP 5.3.3, this will fix many Plugins UI builds
b1bd993 
Refs #7324
mattab added a commit that referenced this issue Mar 8, 2015
@mattab
Running builds on PHP 5.3.3, this will fix many Plugins UI builds
d5c262d 
Refs #7324

Running builds on PHP 5.3.3, this will fix many Plugins UI builds
Refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.11.2
Development

No branches or pull requests
1 participant
@mattab