Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-out page doesn't take DNT into account #7317

Closed
ArnY opened this issue Feb 27, 2015 · 7 comments
Closed

Opt-out page doesn't take DNT into account #7317

ArnY opened this issue Feb 27, 2015 · 7 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.12.0

Comments

@ArnY
Copy link
Contributor

ArnY commented Feb 27, 2015

On a DNT enabled piwik instance, the opt-out page will still tell the user he/she is being tracked even though the user has DNT enabled.

The opt-out page shouldn't rely solely on the piwik_ignore cookie and should also take into account the DNT header sent by the user's browser. The page could let the user know that he/she isn't being tracked because of the DNT setting and not because he/she is explicitly excluded by piwik.
@mattab
Copy link
Member

mattab commented Mar 1, 2015

Hi @ArnY thanks for the feature suggestion, it would make a lot of sense indeed 👍

  • If DNT is enabled server side,
    • Look if DNT header is set and if so, directly show to user he is opted-out
    • we probably should write that he is opted-out thanks to DNT

@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Mar 1, 2015
@mattab mattab added this to the Mid term milestone Mar 1, 2015
@ArnY
Copy link
Contributor Author

ArnY commented Mar 2, 2015

I'll make a pull request to change this but I am unsure on how to deal with new strings. Should I just make the change in the translations I'm familiar with ?

What's more, if a user has DNT enabled, the optout page can not suggest to opt in. So the whole form will be replaced by a message explaining that the user isn't being tracked because the browser reported the user wasn't willing to and since this is a browser setting the user will not be able to opt in as long as the setting is on.

@mattab
Copy link
Member

mattab commented Mar 2, 2015

Great to hear you consider writing a pull request!

you need to write the translation in English as well, but we can review it aftewards so don't worry.

btw An alternative to hiding the form could be to display the checkbox (un-checked) and grey it out with " disabled="disabled" to show that it's not possible to opt-in.

ArnY added a commit to ArnY/piwik that referenced this issue Mar 3, 2015
@ArnY
Take DNT into account cf matomo-org#7317
e3217a2
@ArnY
Copy link
Contributor Author

ArnY commented Mar 3, 2015

e3217a2 uses class DoNotTrackHeaderChecker to check if DNT headers were sent. If so, the user gets a message explaining that his browser reported he/she didn't want to be tracked and that he/she can not opt in with DNT enabled.

I chose not to display the form, even with the checkbox unchecked and disabled since the user will most probably not have the optout cookie so displaying an unchecked checkbox would lead the user to think that if he/she was to disable DNT he/she would be opted out by default. Which is false, they would be tracked by default.

@mattab
Copy link
Member

mattab commented Mar 3, 2015

I chose not to display the form, even with the checkbox unchecked and disabled since the user will most probably not have the optout cookie so displaying an unchecked checkbox would lead the user to think that if he/she was to disable DNT he/she would be opted out by default. Which is false, they would be tracked by default.

Good point 👍

@mattab
Copy link
Member

mattab commented Mar 3, 2015

@ArnY your change looks good! could you issue a pull request?

ArnY added a commit to ArnY/piwik that referenced this issue Mar 4, 2015
@ArnY
Take DNT into account cf matomo-org#7317
426e5c9
mattab pushed a commit that referenced this issue Mar 11, 2015
Merge pull request #7352 from ArnY/dntOptOut
cdb6840 
Take DNT into account cf #7317
@mattab
Copy link
Member

mattab commented Mar 11, 2015

Well done @ArnY - done in #7352

@mattab mattab closed this as completed Mar 11, 2015
@mattab mattab modified the milestones: Piwik 2.12.0, Mid term Mar 11, 2015
@sgiehl sgiehl mentioned this issue Mar 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
2 participants
@ArnY @mattab