Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $skipAggregationOfSubTables from codebase #7310

Closed
mattab opened this issue Feb 27, 2015 · 0 comments
Closed

Remove $skipAggregationOfSubTables from codebase #7310

mattab opened this issue Feb 27, 2015 · 0 comments
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 27, 2015

The goal of this issue is to clean up some platform code, in particular remove all the code around $skipAggregationOfSubTables variable. This was introduced by myself in 3d3f3c0

But unfortunately this is completely useless code. It must be killed and removed from codebase!

@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Feb 27, 2015
@mattab mattab added this to the Piwik 2.12.0 milestone Feb 27, 2015
@mattab mattab self-assigned this Feb 27, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 27, 2015
mattab added a commit that referenced this issue Feb 27, 2015
@mattab mattab modified the milestones: Piwik 2.11.2, Piwik 2.12.0 Mar 2, 2015
ArnY pushed a commit to ArnY/piwik that referenced this issue Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

1 participant