match log lines when multiple spaces are between individual log fields. #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '\S+ \S+ \S+ \S+ "\S+ (?P<path>.*?) \S+" (?P<status>\S+) \S+ (?P<length>\S+) ' | ||
| '\S+ \S+ \S+ "(?P<referrer>.*?)" "(?P<user_agent>.*?)"' | ||
| '\S+\s+(?P<host>\S+)\s+\[(?P<date>.*?)\s+(?P<timezone>.*?)\]\s+(?P<ip>\S+)\s+' | ||
| '\S+\s+\S+\s+\S+\s+\S+\s+"\S+\s+(?P<path>.*?)\s+\S+"\s+(?P<status>\S+)\s+\S+\s+(?P<length>\S+)\s+' |
There was a problem hiding this comment.
would it work to use \s* to match any number of spaces?
There was a problem hiding this comment.
No, then 308803 might get matched as the status instead of 308 if the log line has 308 803. Fields have to be separated by spaces.
There was a problem hiding this comment.
would \s+ match 1 or more spaces?
There was a problem hiding this comment.
Yes, that's what the + is for.
added 2 commits
February 25, 2015 14:58
…ual log fields. Includes python tests.
…e spaces are parsed.
diosmosis
force-pushed
the
7228_multiple_spaces_import_logs
branch
from
b56cc20
to
97bb8ab
Compare
mattab
changed the title
|
Looks good to me 👍 |
mattab
pushed a commit
that referenced
this pull request
Mar 2, 2015
match log lines when multiple spaces are between individual log fields.
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7228
As title. Includes python tests.
@mattab Review please.