Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If session is writable do not remove or add a notification #7283

Merged
merged 2 commits into from Mar 2, 2015
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 24, 2015

refs #7274
Please do not directly merge. First I want to understand which notification it wants to trigger in Goals overview.

Haven't tested it!

Please do not directly merge. First I want to understand which notification it wants to trigger in Goals overview.

Haven't tested it!
@tsteur tsteur changed the title refs #7274 If session is writable do not remove or add a notification If session is writable do not remove or add a notification Feb 24, 2015
@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 24, 2015
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Feb 24, 2015
@mattab mattab added this to the Piwik 2.11.2 milestone Feb 24, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 24, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Mar 1, 2015

👍 can confirm that the "Goals Overview" widget works with that branch.

mattab pushed a commit that referenced this pull request Mar 2, 2015
If session is writable do not remove or add a notification
@mattab mattab merged commit 52a0652 into master Mar 2, 2015
@mnapoli mnapoli deleted the 7274 branch March 2, 2015 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants