Fixes #7247, move default Formatter class to new Numeric metrics formatt.er and use in Graph visualization. #7262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2015 04:53
…atter and use in Graph visualization since jqplot requires numeric values in JSON data.
…lugins. Move Numeric formatter to CoreVisualizations and do not mark w/ @api.
mattab
added
the
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Feb 23, 2015
Fixes #7247, move default Formatter class to new Numeric metrics formatt.er and use in Graph visualization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Since jqplot requires numeric values in JSON data, formatting from within graph visualizations should be done differently. Creating a new formatter and using it in the graph visualization fixes #7247.
Includes a modification to the Evolution graph UI test.
An alternative solution is to make rate metrics convert quotients to percents w/o the '%' string in compute, but I consider this to be an improper solution, as it makes the datatable values less usable (ie, users would have to undo the
* 100in order to apply the rate).After merging, TasksTimetable will have to be updated since it uses Formatter (which is an interface in this pull request).