automatically configure database_tests config for developers when running tests. #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
| $dbTests = $config->database_tests; | ||
|
|
||
| if ($dbTests['username'] === '@USERNAME@') { | ||
| $dbTests['username'] = 'root'; |
There was a problem hiding this comment.
Why not set it to Config::getInstance()->database['username']? Maybe I missed some discussion on this.
There was a problem hiding this comment.
Basically, I just wanted to have it as before. Before, in global config was the default username root which I changed to @USERNAME@. By setting it back to root for developers who update I make sure it is the same as before. In theory, developers could use a different username for there regular database in $dbTests['username']. I used to have this in the piwik-dev-environment where I had one user piwik for the normal database that Piwik uses and one user root for tests.
|
FYI: this pr needs a rebase |
…ers when running tests. I also replaced the check that does a request against Piwik to check whether it is installed with `SettingsPiwik::isInstalled()` as discussed recently
|
done |
mattab
pushed a commit
that referenced
this pull request
Feb 23, 2015
automatically configure database_tests config for developers when running tests.
mattab
added a commit
that referenced
this pull request
Sep 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6635
I also replaced the check that does a request against Piwik to check
whether it is installed with
SettingsPiwik::isInstalled()as discussedrecently