Faster dashboard and sparklines by closing the session early #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ajax requests are made within widget or when sparklines are requested
…ted from dashboard or allwebsites
…ion. Sometimes, eg when module=API, we do not start a session. If any code part during such a request uses SessionNamespace although we did not start a session, Zend_Session_Namespace will start a Zend_Session which does not respect our configuration. It would use default Zend Session options and therefore probably file based sessions. Therefore, we force the creation of a "Piwik session". If we have created the session before it won't be started again.
| @@ -466,6 +466,20 @@ protected function prepareDispatch($module, $action, $parameters) | |||
| && ($module !== 'API' || ($action && $action !== 'index')) | |||
| ) { | |||
| Session::start(); | |||
|
|
|||
There was a problem hiding this comment.
I was wondering where to put this code here. If we had a Router (refs #6403) it could be maybe related to this. For now I'm ok with having it in FrontController as it is probably not worth it to write an API for this yet.
tsteur
added
not-in-changelog
|
👍 (small thing, I'll rename Referer -> Referrer in var name) |
mattab
pushed a commit
that referenced
this pull request
Feb 19, 2015
Faster dashboard and sparklines by closing the session early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7104