Add segment name in mail subjet and filename #7238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding segment name in report title (mail subject and filename) to allow recipient to differentiate reports when receiving reports on a per-segment basis: "sitename - segmentname - date" instead of "sitename - date"
Add segment name in mail subjet and filename
mattab
added
the
Enhancement
| @@ -450,6 +450,9 @@ public function generateReport($idReport, $date, $language = false, $outputType | |||
| $description = str_replace(array("\r", "\n"), ' ', $report['description']); | |||
|
|
|||
| list($reportSubject, $reportTitle) = self::getReportSubjectAndReportTitle(Site::getNameFor($idSite), $report['reports']); | |||
|
|
|||
| if(is_array($segment) && strlen($segment['name'])) $reportTitle .= " - ".$segment['name']; | |||
There was a problem hiding this comment.
could you use the same coding style eg. add the { and put the $reportTitle on a new line? thanks!
|
Thanks @ArnY for the pull request. I put a little feedback |
|
closing this pull request. Replaced by #7243 (cleaner, commented and respects coding styles) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding segment name in report title (mail subject and filename) in order to allow recipients to differentiate reports when receiving reports on a per-segment basis:
"sitename - segmentname - date" instead of "sitename - date"