Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pluging Transitions - possible URL mismatch #7236

Closed
dscaravaggi opened this issue Feb 18, 2015 · 6 comments
Closed

pluging Transitions - possible URL mismatch #7236

dscaravaggi opened this issue Feb 18, 2015 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Milestone
Backlog (Help wan...

Comments

@dscaravaggi
Copy link

Hi all,
I'm a newbie Piwik programmer,
I noticed that usage of textarea post parameters at line 34 of
plugins/Transitions/javascripts/transitions.js

may genarate inconsistent url when JSON decoded serverside
on my dev laptop I inserted a "difensive" line:

    link = $('<textarea>').html(encodeURIComponent(link)).val();

and of course I added the symmetric decode (plugins/Transitions/API.php line 68)

    $l_uriDecodeString = urldecode( $actionName );
    $actionName = $l_uriDecodeString;

maybe there is another more elegant way to "sanitize" strange url with a lot of ampersand querystring etc... but this help ma a lot with MS sharepoint sites.

Thanks in advance
Diego
@dscaravaggi
Copy link
Author

I received positive feedback from the Intranet sharepoint webserver. Transition graphs are correctly generated for any page and url with space ampersand and à ù è etc....

@mattab
Copy link
Member

mattab commented Feb 18, 2015

Hi @dscaravaggi can you detail how the bug can be reproduced? What kind of URLs were not working in Transitions, and are working after your patch? before we fix the issue we must be able to reproduce it. Thanks

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 18, 2015
@mattab mattab added this to the Short term milestone Feb 18, 2015
@dscaravaggi
Copy link
Author

Sorry for my late answer, I reproduced myself on the laptop, I prepared a trivial php script with this url:
http://127.0.0.1:9092/test_tracker_Mysql/test2_mysql.php?param2=hr41%C3%A8%C3%A8&param6=hr6%C3%A0%C3%A01. (Github is smarter and prevented me to paste such Italian accent).

http://127.0.0.1:9092/test_tracker_Mysql/test2_mysql.php?param2=h41èé?param4=ùù0

try It with and without my suggestions. (I used v 2.9.1 but source code is the same)
issuetransitions

I hope this could help.

@mattab
Copy link
Member

mattab commented Feb 23, 2015

@dscaravaggi we made a few fixes in 2.10.0 and even 2.11.0

could you try again with 2.11.0 and confirm whether you can still reproduce this issue?

@dscaravaggi
Copy link
Author

I've just made the test with 2.11.1 and the problem is not present.
I ask to close this not a bug

@mattab
Copy link
Member

mattab commented Feb 24, 2015

Great news @dscaravaggi

@mattab mattab closed this as completed Feb 24, 2015
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @dscaravaggi