Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piwik.js double encodes the url and referrer when they are detected automatically #7220

Closed
tsteur opened this issue Feb 16, 2015 · 0 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Feb 16, 2015

location.href and top.document.referer seem to be already URL encoded. At least in the browsers we tested. When tracking, we do encode them again meaning they are double url encoded which is wrong. Even worse some browsers use uppercase and some browsers use lowercase for the url encoding meaning we store 2 actions for the same URL. See #7209 . It also causes that it is not possible to segment for those URLs see #7218

Solution should be most likely to always url-decode the url and referrer before url-encoding them again (which is done when the request is sent)

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 16, 2015
@tsteur tsteur added this to the Piwik 2.11.0 milestone Feb 16, 2015
tsteur added a commit that referenced this issue Feb 16, 2015
…referrer.

location.href and top.document.referer are both already URL encoded.
To prevent double encoding we need to decode them.
@tsteur tsteur self-assigned this Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant