Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Toppreise.ch as search engine #7216

Closed
iquito opened this issue Feb 16, 2015 · 5 comments
Closed

Adding Toppreise.ch as search engine #7216

iquito opened this issue Feb 16, 2015 · 5 comments
Assignees
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@iquito
Copy link

iquito commented Feb 16, 2015

Toppreise.ch is a products search engine in Switzerland, and the following lines should be added to core/DataFiles/SearchEngines.php:

'www.toppreise.ch'      => array('Toppreise', 'search', null, 'iso-8859-1'),
'toppreise.ch'      => array('Toppreise', 'search', null, 'iso-8859-1'),
'fr.toppreise.ch'      => array('Toppreise', 'search', null, 'iso-8859-1'),
'de.toppreise.ch'      => array('Toppreise', 'search', null, 'iso-8859-1'),
'en.toppreise.ch'      => array('Toppreise', 'search', null, 'iso-8859-1'),
'{}.toppreise.ch'      => array('Toppreise', 'search', null, 'iso-8859-1'), 

I am not sure if some lines are redundant, that is why I am just posting it without a pull request.

@sgiehl sgiehl self-assigned this Feb 16, 2015
@sgiehl sgiehl added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Feb 16, 2015
@sgiehl
Copy link
Member

sgiehl commented Feb 18, 2015

I just took a look at www.toppreise.ch. I don't see how the keyword could be passed with the referrer. All external links seem to go through a proxy script.
Do you have a referrer url in your tracking data containing a keyword?

@iquito
Copy link
Author

iquito commented Feb 19, 2015

Yes, most links from toppreise have a referrer with the search keywords - that is why I implemented it in my Piwik installation and bringing it up here ;-)

The proxy script probably just makes a HTTP redirect, so the proxy page is not saved as referrer, because I never have something like http://www.toppreise.ch/call.php as referrer, always the page the user was on.

@mattab mattab added this to the Piwik 2.12.0 milestone Feb 19, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Feb 19, 2015
@sgiehl
Copy link
Member

sgiehl commented Feb 19, 2015 via email

@iquito
Copy link
Author

iquito commented Feb 19, 2015

These are all referrer log entries from Toppreise I got recently:

http://www.toppreise.ch/index.php?search=Sissel+Sitfit+Plus
http://www.toppreise.ch/index.php?search=Kniebandage
http://www.toppreise.ch/index.php?search=Epitact+Hallux+Korrekturschiene

Important in my entry in SearchEngines is the iso-8859-1 encoding, otherwise characters like äöü are falsly assumed to be UTF-8, whereas Toppreise is still fully iso-8859-1.

@tsteur
Copy link
Member

tsteur commented Feb 22, 2015

Sorry that last commit was meant for #7261 !

@mattab mattab modified the milestones: Piwik 2.12.0, Piwik 2.11.2 Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

4 participants