Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate actions are logged for lower/upper case encoded URL #7209

Closed
tsteur opened this issue Feb 15, 2015 · 6 comments
Closed

Duplicate actions are logged for lower/upper case encoded URL #7209

tsteur opened this issue Feb 15, 2015 · 6 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Feb 15, 2015

For example piwikjapan.org/%E6%A9%9F%E8%83%BD%E8%AA%AC%E6%98%8E/4695 and piwikjapan.org/%e6%a9%9f%e8%83%bd%e8%aa%ac%e6%98%8e/4695. Type is always 1.

Most likely the problem is that we url encode in the browser and different browsers might use uppercase or lowercase: https://github.com/piwik/piwik/blob/2.11.0-b7/js/piwik.js#L2917

We'd need to solve this in the backend and replace all lowercase url encoded values with uppercase (or the other way around but uppercase seems to be more common).

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 15, 2015
@mattab mattab added this to the Piwik 2.12.0 milestone Feb 15, 2015
@tsteur
Copy link
Member Author

tsteur commented Feb 16, 2015

URL and referrer should be no longer stored URL encoded meaning this issue should no longer occur. To be sure we will check Piwik demo in 2-3 weeks whether there are still any URL encoded values with lower/uppercase difference.

@tsteur tsteur self-assigned this Feb 20, 2015
@mattab
Copy link
Member

mattab commented Mar 12, 2015

@tsteur could you confirm / check this one is fixed as we suspected?

@tsteur
Copy link
Member Author

tsteur commented Mar 12, 2015

It's hard to tell. PiwikJapan is still using an old piwik.js. Do we have another site with such urls?

@mattab
Copy link
Member

mattab commented Mar 12, 2015

unfortunately we don't. I've sent an email asking PiwikJapan team if they can update the Piwik running there.

@mattab
Copy link
Member

mattab commented Mar 12, 2015 via email

@tsteur
Copy link
Member Author

tsteur commented Mar 15, 2015

I couldn't find any url encoded entries of the last days and also tested it myself again.

Please note if someone still experiences this issue, check the expires header for piwik.js. There might be still some users with an older piwik.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants