Renamed SegmentFilter metadata to segment #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and extracted code into a filter
…re a search, do not display segment icon in subtables of events
|
some system tests are failing in #7200 after adding the new segment part otherwise looks good 👍 |
…ilter within a filter and run them recursive. not sure if recursive is a good idea though
|
I'm still working on it re the other changes |
…ubtables since they can belong to different repots and need different segments
…re queued filters are applied which allows us to use the prependSegment filter in combination with AddSegmentValue
…e run, otherwise it would not be converted
* No longer any segmentValue in subtables, this was a bug * Referer.getReferrerType should not have any segments * Order of some segments slightly changed in metadata output since we do process them earlier now * Append segemnt refererType=search to keywords
|
done |
mattab
pushed a commit
that referenced
this pull request
Feb 16, 2015
Renamed SegmentFilter metadata to segment
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a bug re VisitTime date creation, extracted that code in a filter and wrote test for it.
refs #4633