Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Action" caching #7198

Closed
ThaDafinser opened this issue Feb 13, 2015 · 1 comment
Closed

"Action" caching #7198

ThaDafinser opened this issue Feb 13, 2015 · 1 comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@ThaDafinser
Copy link
Contributor

As a follow up to #7104 to gain even more GUI performance, i think it would be good to cache reports and other pages if possible.

All reports, which does not process data from the current day would/should be save to cache.

How to cache it? I think the easiest way would be a complete response cache.
-> take the complete url with all variables and generate a cacheId
-> save the response to cache

If a new request comes in, generate again the cacheId and check if a valid cache is around.
-> when yes return it
-> when no -> go to the normal process

Saving the cache could happen in the FrontController: https://github.com/piwik/piwik/blob/master/core/FrontController.php#L96

Check for the cache could even happen before...e.g. in the index.php or bootstrap.php

Some thoughts:

  • maybe the parameters are too different all the time, that nearly no cache item will be hit?
  • Cache check needs also time and if the miss rate is high, the benefit is the opposite we want
  • Not possible to cache: "live widgets" and reports for the current day

What do you think?

@mattab
Copy link
Member

mattab commented Feb 15, 2015

Heya, can you post your thoughts in: #7143

@mattab mattab closed this as completed Feb 15, 2015
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants