New icon in all reports: let me segment by visitors matching this row's criteria #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattab do you mind having a look? And maybe also test it? |
|
this is an EPIC PULL REQUEST |
|
really great... this is such a killer feature!! 👍 Only feedback
Merging and will deploy on demo |
mattab
pushed a commit
that referenced
this pull request
Feb 13, 2015
New icon in all reports: let me segment by visitors matching this row's criteria
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #4633
works for most reports. It won't fix the issue completely but it would be usable. Once this is merged I'd like to see if it is possible the solve it in core and not in each report but not sure it will be.
The width of the visitor log is a bit of a problem but that's kinda similar to widget area etc. It works though.
Segment filter generation works in two steps. Either we directly set a
segmentFiltermetadata or first asegmentValuemetadata which then gets converted to asegmentFilterin post process data table. We could always generate asegmentFilterdirectly but it is much less code and easier for now. Will see later again as it is harder to understand this two step thing. If we'd always want to generate asegmentFilterdirectly we have to instantiate hardcoded reports in each API method and declare thesegmentValuefor each API method instead of centralised in somegetDataTablemethods etc.