Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings + coding standards with PHP-CS-Fixer #7186

Closed
ThaDafinser opened this issue Feb 12, 2015 · 4 comments
Closed

Fix warnings + coding standards with PHP-CS-Fixer #7186

ThaDafinser opened this issue Feb 12, 2015 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
3.0.0-b1

Comments

@ThaDafinser
Copy link
Contributor

Hello together,

there i a small little helper with a huge benefit i use currently for all my projects:
https://github.com/FriendsOfPHP/PHP-CS-Fixer

This little does not only checking for coding standards, it can be actually used to apply them.
There are e.g. tons of unused use statements in Piwik, which would be automatically removed by that tool

Also that tool can be executed as "dry-run" to only report problems, so it can be included in the travis build process.

piwik
@mattab mattab changed the title Warnings + coding standards Fix warnings + coding standards with PHP-CS-Fixer Feb 19, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Feb 19, 2015
@mattab mattab added this to the Mid term milestone Feb 19, 2015
@mattab
Copy link
Member

mattab commented Feb 19, 2015

Hi @ThaDafinser thanks for the suggestion. It could make sense to set this up sometime.

@ThaDafinser ThaDafinser mentioned this issue Apr 21, 2015
Closed
3 tasks
@mattab mattab mentioned this issue May 20, 2015
Closed
@fabiocarneiro fabiocarneiro mentioned this issue May 21, 2015
Closed
@mnapoli
Copy link
Contributor

mnapoli commented May 21, 2015

Related: I'd love to be able to use http://fabbot.io/ someday as it can automatically fix your pull requests (so the attention needed and effort is really low). The problem is that it's still in beta and only works for the Symfony repositories for now.

@mattab
Copy link
Member

mattab commented May 24, 2015

Related @kaz231 pointed out there is a tool in PhpStorm as well, which could maybe help until we can automate everything on CI. https://confluence.jetbrains.com/display/PhpStorm/PHP+Code+Sniffer+in+PhpStorm

@ThaDafinser ThaDafinser mentioned this issue Sep 3, 2015
Closed
@mattab mattab modified the milestones: 3.0.0-b1, Mid term Oct 13, 2015
@mattab
Copy link
Member

mattab commented Jan 18, 2016

See also our follow up issue Automatically convert our code base to use a consistent code style #9545

@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
3.0.0-b1
Development

No branches or pull requests
3 participants
@mattab @ThaDafinser @mnapoli