Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom variable segments should not depend on database column index #7183

Closed
diosmosis opened this issue Feb 11, 2015 · 0 comments
Closed

custom variable segments should not depend on database column index #7183

diosmosis opened this issue Feb 11, 2015 · 0 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@diosmosis
Copy link
Member

Currently, there are two segments per custom variable slot in the DB (one for name and one for value). These segments look only for custom variables in a specific slot, so if a user tracks the same custom variable to two different columns, custom variable segmentation breaks. This is counter-intuitive, just because a custom variable pair is stored in two different places, doesn't mean they shouldn't be considered the same. It's also more complicated to track.

Ideally, there should be just two segments customVariableName and customVariableValue. The segments could result in an SQL OR across all available custom variable columns.

@diosmosis diosmosis added the duplicate For issues that already existed in our issue tracker and were reported previously. label Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

1 participant