Refactored the SEO plugin to make it extensible and error-proof #7174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and error-proof - SEO metrics are returned by `MetricsProvider` implementations - a new event `SEO.getMetricsProviders` allows other plugins to register `MetricsProvider` - errors while connecting to a 3rd party service are now logged as warning, and shown in the widget as `-` instead of the values.
mnapoli
changed the title
mnapoli
added
the
c: Platform
| @@ -0,0 +1,45 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
- piwik file headers missing in some of the new files
|
Very nice refactor! It would be nice to create a new component for SEO metrics, feel free to do it quick if you like the idea :-) |
|
OK! |
|
By the way, by OK I meant I'll look into it later but not in this PR especially since we need it for 2.11 ;) So ready to be merged if all OK? |
|
Looks good, I'll test it on demo2 and demo! |
mattab
pushed a commit
that referenced
this pull request
Feb 12, 2015
Refactored the SEO plugin to make it extensible and error-proof
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-instead of the valuesSEO.getMetricsProvidersallows other plugins to registerMetricsProviderAlso kinda related to #4172: as I said there I think we could move our implementations (that are now more decoupled) into a new Piwik "SEO" component.