Scheduled reports: do not show "Users" metric when value is zero #7171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven site. looking for other solutions as well
…her userId is used or not
…s no longer returned in those examples
…iced when handling multiple period dates and period=range
This is an alternative solution to fix this problem. The difference here is that we only do an additional call to VisitsSummary::get if users is 0. The disadvantage is that eg API.getReportMetadata will report that nb_users exist but the API.getProcessedReport might not return it. This already caused some problems while trying to implement it like this as API.getProcessedReport will add all metrics returned by getReportMetadata automatically. So even if we remove nb_users in the API output of VisitsSummary.get it would be still added again. Another disadvantage of this solution is that the code is more fragile as we have to map parameters like $params[0] to idSite, $params[1] to period, ...
…l mergeChildren as it would change the dataTable
…from processed report now
…xact number of users
| if ($segment != null) { | ||
| $params['segment'] = urlencode($segment['definition']); | ||
| } else { | ||
| $paras['segment'] = false; |
|
@tsteur left small feedback, good to merge after these 👍 |
mattab
added
Enhancement
tsteur
added a commit
that referenced
this pull request
Feb 13, 2015
Scheduled reports: do not show "Users" metric when value is zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6705
Users will be removed from the processed report in case there are no users, and there were no users for that month. To check for this we have to request
VisitsSummary.get. The users metric will always appear in API.getReportMetadata even if it is not used for a site. This is ok according to @mattab