@jantlwoomy opened this Pull Request on February 10th 2015 Contributor

Store visitorID related to userID to cookies.
Please see https://github.com/piwik/piwik/pull/6838 to additional info

@mattab commented on February 13th 2015 Member

Thanks @jantlwoomy for the PR, i've made a little fix (added .length) but looks correct now. Do you mind testing 2.11.0-b5 which includes the fix in the minified piwik.js and confirm it works OK for you?

Also @asafyish maybe you could help us test the beta 5 and confirm it works?

@asafyish commented on February 13th 2015

I will try to verify it today.

@asafyish commented on February 14th 2015

It doesn't seem to work correctly.
This is what I did:

  1. Visit page A and run setUserId with id 'asafyish'.
  2. Visit page B and run setUserId with id 'asafyish'.
  3. Refresh page B without running setUserId.
    After steps 1 & 2 the situation was good, I had one unique visit.
    After step 3, I had 2 visits, even though I already called setUserId in steps 1 & 2.
    I expected that after step 3 I will still have just one unique visit.
    If I am using https://github.com/piwik/piwik/pull/6838 then it works correctly.

Using piwik.js from 2.11.0-b7;

@mattab commented on February 16th 2015 Member

@asafyish I tested this and for me it works correctly, I see only one visit even after removing the call to set setUserId - if you still have issue with the latest beta, please attach the files to reproduce and i'll take a look!

This Pull Request was closed on February 12th 2015
Powered by GitHub Issue Mirror