Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When User ID is used, set the first party cookie UUID to this User ID #7167

Merged
merged 2 commits into from Feb 12, 2015
Merged

When User ID is used, set the first party cookie UUID to this User ID #7167

merged 2 commits into from Feb 12, 2015

Conversation

jantlwoomy
Copy link
Contributor

Store visitorID related to userID to cookies.
Please see #6838 to additional info

@mattab mattab changed the title Cookie visitor When User ID is used, set the first party cookie UUID to this User ID Feb 12, 2015
mattab pushed a commit that referenced this pull request Feb 12, 2015
Merge pull request #7167 from jantlwoomy/cookie_visitorID
73b51c1 
When User ID is used, set the first party cookie UUID to this User ID
@mattab mattab merged commit 73b51c1 into matomo-org:master Feb 12, 2015
mattab added a commit that referenced this pull request Feb 13, 2015
@mattab
Refs #7167 add .length and update minified piwik.js
3655204
@mattab
Copy link
Member

mattab commented Feb 13, 2015

Thanks @jantlwoomy for the PR, i've made a little fix (added .length) but looks correct now. Do you mind testing 2.11.0-b5 which includes the fix in the minified piwik.js and confirm it works OK for you?

Also @asafyish maybe you could help us test the beta 5 and confirm it works?

@mattab mattab added this to the Piwik 2.11.0 milestone Feb 13, 2015
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Feb 13, 2015
mattab pushed a commit that referenced this pull request Feb 13, 2015
Fix typo in my previous commit refs #7167
9fbe4ce
@asafyish
Copy link

I will try to verify it today.

@asafyish
Copy link

It doesn't seem to work correctly.
This is what I did:

  1. Visit page A and run setUserId with id 'asafyish'.
  2. Visit page B and run setUserId with id 'asafyish'.
  3. Refresh page B without running setUserId.
    After steps 1 & 2 the situation was good, I had one unique visit.
    After step 3, I had 2 visits, even though I already called setUserId in steps 1 & 2.
    I expected that after step 3 I will still have just one unique visit.
    If I am using Store visitorID related to userID to cookies #6838 then it works correctly.

Using piwik.js from 2.11.0-b7;

@mattab
Copy link
Member

mattab commented Feb 16, 2015

@asafyish I tested this and for me it works correctly, I see only one visit even after removing the call to set setUserId - if you still have issue with the latest beta, please attach the files to reproduce and i'll take a look!

@mattab mattab mentioned this pull request Apr 17, 2015
Closed
@jantlwoomy jantlwoomy deleted the cookie_visitorID branch June 24, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jantlwoomy @mattab @asafyish