New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some performance improvements for the all websites dashboard #7162
Conversation
…report. I tested it with 4k websites. The change made it only a couple of seconds faster but requesting 4k websites would still take 4-8 seconds even if only 10 sites of them are actually requested. For example before we did request each site 3 times (12k times in total and triggered 12k events etc) which should be no longer the case. The last `clearSiteCache` was there to free some memory but I think it shouldn't be problematic to remove it. Also I removed one 'sort' as a lot of time is wasted there. It should be in theory sorted afterwards anyway again. Need to see test results whether this change is good or not.
…ere not correctly returned
…ts in only one requested site but uses multi period
There is a failing test re |
the expected files are re-used from the test OneVisitorTwoVisits |
There's a bug in the output of the path then... That's problematic since they have apparently different formats. Eg OneVisitor returns a different order than BC1xTest. Will have a look tmrw at this. Don't wanna deal with this today, already enough... ;) |
I think the tests should be fixed now |
Some performance improvements for the all websites dashboard
Let's remember to test this on demo2 and demo to be safe @tsteur (i'll do new beta tomorrow) |
and nice to see faster All Websites dashboard, step by step 👍 |
refs #6809
I tested it with 4k websites. The change makes it only a couple of seconds faster
and requesting 4k websites would still take 4-8 seconds even if only 10 sites of
them are actually requested. For example before we did request each site 3 times
(12k times in total and triggered 12k events etc) which should be no longer the case.
The last
clearSiteCache
was there to free some memory but I think it shouldn'tbe problematic to remove it. Also I removed one 'sort' as a lot of time is wasted
there. It should be in theory sorted afterwards anyway again. Need to see test
results whether this change is good or not.
This doesn't fix the issue #6809, it is only one part of it.
There might be a failing test but this one is also failing on master.