Added a new "Development" language that shows the raw translation IDs #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added
the
Enhancement
mnapoli
force-pushed
the
translation-id-language
branch
from
fc427eb
to
4e6c3b6
Compare
| @@ -88,7 +88,7 @@ function prepareServerVariables() | |||
|
|
|||
| // General requirement checks & help: a webserver must be running for tests to work if not running UnitTests! | |||
| if (empty($_SERVER['argv']) || !in_array('UnitTests', $_SERVER['argv'])) { | |||
| checkPiwikSetupForTests(); | |||
| // checkPiwikSetupForTests(); | |||
There was a problem hiding this comment.
little error here - btw maybe we have a problem with this function if you need to comment it?
|
Left some feedback, looks good to me and nice use of DI! |
mattab
added
the
Pull Request WIP
mnapoli
force-pushed
the
translation-id-language
branch
from
4e6c3b6
to
89a840d
Compare
|
PR updated with feedback. |
…on id This language is shown when development mode is enabled.
mnapoli
force-pushed
the
translation-id-language
branch
from
89a840d
to
3bf3589
Compare
mattab
pushed a commit
that referenced
this pull request
Feb 9, 2015
Added a new "Development" language that shows the raw translation IDs
|
👍 |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7094
This language is shown when development mode is enabled.