Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SEO widget should be displayed even if when a http service calls fail #7153

Closed
mattab opened this issue Feb 9, 2015 · 1 comment
Closed

The SEO widget should be displayed even if when a http service calls fail #7153

mattab opened this issue Feb 9, 2015 · 1 comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Piwik 2.11.0

Comments

@mattab
Copy link
Member

mattab commented Feb 9, 2015

When building the SEO widget, we collect metrics from various web services eg. Google, microsoft, whois, etc. In some cases the HTTP calls can fail. For example Whois may be rate limited to 100 requests per hour.

Possible steps of this issue

  1. investigate what possible limits are, check whether we can avoid them
  2. check that errors are logged (as a warning maybe?)
  3. that the SEO widget is displayed with the failed value as - or Network error (and other values displayed correctly).

follows up #7103
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Feb 9, 2015
@mattab mattab modified the milestones: Short term, Piwik 2.12.0, Mid term Feb 9, 2015
mnapoli added a commit that referenced this issue Feb 10, 2015
@mnapoli
#7153 #4172 #7107 Refactored the SEO plugin to make it more extensibl…
9d4bbce 
…e and error-proof

- SEO metrics are returned by `MetricsProvider` implementations
- a new event `SEO.getMetricsProviders` allows other plugins to register `MetricsProvider`
- errors while connecting to a 3rd party service are now logged as warning, and shown in the widget as `-` instead of the values.
@mnapoli mnapoli mentioned this issue Feb 11, 2015
Merged
@mattab mattab modified the milestones: Piwik 2.11.0, Mid term Feb 11, 2015
@tsteur
Copy link
Member

tsteur commented Feb 13, 2015

So what are the request limits for each service?

@mnapoli mnapoli mentioned this issue Feb 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
2 participants
@tsteur @mattab