Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Arora is identified as Safari #715

Closed
anonymous-matomo-user opened this issue May 14, 2009 · 6 comments
Closed

Browser Arora is identified as Safari #715

anonymous-matomo-user opened this issue May 14, 2009 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

This is because UserAgentParser lacks detection information for Arora. Besides, it looks strange to see Safari on Linux ;)

Example UA-String: "Mozilla/5.0 (X11; U; Linux; en-US) AppleWebKit/527+ (KHTML, like Gecko, Safari/419.3) Arora/0.6"

Maybe it is enough to include Arora to UserAgentParser::browsers array? I cannot test atm.

@anonymous-matomo-user
Copy link
Author

Attachment: Patch that makes Piwik identify Arora
useragentparser.diff

@anonymous-matomo-user
Copy link
Author

So, now i could. I did what i supposed in the description, tested it with the test.php and it is satisfying. Patch is attached.

@anonymous-matomo-user
Copy link
Author

Attachment: Browser image for UserSettings Plugin
AR.gif

@anonymous-matomo-user
Copy link
Author

Attachment: Assign Arora to KHTML family
UserSettings.diff

@anonymous-matomo-user
Copy link
Author

I yesterday evening how the browser family is detected... now i found out ;) Patch for UserSettings is now attached as well.

@mattab
Copy link
Member

mattab commented May 16, 2009

fixed in [1125]

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants