Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the endDate is valid when switching between websites #7138

Merged
merged 1 commit into from Feb 6, 2015
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 4, 2015

refs #6811

Imagine website is created on 2015-12-20, if current selected date
was eg 2015-04-18,2015-04-29 the startDate was automatically fixed
already to 2015-12-20,2015-04-29 but not the endDate. This is now
done and it will apply 2015-12-20,2015-12-20.
The code looks a bit more complex as there was another bug that
although it applied 2015-12-20,2015-12-20 it did still
display the date range for 2015-04-18,2015-04-29 in the UI in
the calendar which is wrong. Also I do now fix the date in case
period != range. So period=day&date=2015-04-29 will result in
period=day&date=2015-12-20

…ites

Imagine website is created on 2015-12-20, if current selected date
was eg 2015-04-18,2015-04-29 the startDate was automatically fixed
already to 2015-12-20,2015-04-29 but not the endDate. This is now
done and it will apply 2015-12-20,2015-12-20.
The code looks a bit more complex as there was another bug that
although it applied 2015-12-20,2015-12-20 it did still
display the date range for 2015-04-18,2015-04-29 in the UI in
the calendar which is wrong. Also I do now fix the date in case
period != range. So period=day&date=2015-04-29 would result in
period=day&date=2015-12-20
mattab pushed a commit that referenced this pull request Feb 6, 2015
make sure the endDate is valid when switching between websites fixes #6811
@mattab mattab merged commit 20169ba into master Feb 6, 2015
@mattab
Copy link
Member

mattab commented Feb 6, 2015

looks good!

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 16, 2015
@tsteur tsteur deleted the 6811 branch March 8, 2015 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants