Simplified the cache configuration #7128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
force-pushed
the
simpler-cache-config
branch
from
54c9b96
to
3bf9bfa
Compare
|
A PR to review for you @tsteur |
|
I haven't tested it. Presume it works and can be merged. |
|
Hi @mnapoli feel free to merge after rebase |
|
mnapoli
force-pushed
the
simpler-cache-config
branch
from
3bf9bfa
to
f23c459
Compare
mnapoli
added a commit
that referenced
this pull request
Feb 10, 2015
Simplified the cache configuration
|
Yes, otherwise they don't pass and it improves test execution time |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few simplifications for the cache config.
By the way why use the file cache in tests? I'm afraid of all the possible side-effects.
I also simplified the Translator cache config by simply getting the configured cache (hopefully the file cache in tests will not create problems)
ping @tsteur