Move UI specs into Piwik repository and run UI tests in Piwik repo as well #7125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: tests/PHPUnit/UI tests/PHPUnit/UI/expected-ui-screenshots
|
I will create another pull request moving the ui tests into |
|
well done! very useful |
mattab
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6947
From now on the piwik-ui-tests repository will no longer contains any specs, only the expected screenshots see https://github.com/piwik/piwik-ui-tests/tree/ui_tests
We could rename this UI tests repository if anyone thinks it is important.