Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a class uiTest to the html element in all uiTests. #7123

Merged
merged 1 commit into from Feb 2, 2015
Merged

Add a class uiTest to the html element in all uiTests. #7123

merged 1 commit into from Feb 2, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 2, 2015

This will allow developers to hide elements in the UI tests if needed as not everyone can change override.css etc. For example it allows to hide sparklines or a date that changes all the time and would otherwise always fail the test.

A couple of UI tests fail because of this but this seems to actually fix some random bugs we had before see http://builds-artifacts.piwik.org/ui-tests.master/7139.1/screenshot-diffs/diffviewer.html

@tsteur
Add a class uiTest to the html element in all uiTests.
700c1e7 
This will allow developers to hide elements in the UI tests if needed.
For example sparklines or a date that changes all the time and would
fail the test.
tsteur added a commit that referenced this pull request Feb 2, 2015
@tsteur
Merge pull request #7123 from piwik/uiTestClass
e3b8319 
Add a class uiTest to the html element in all uiTests.
@tsteur tsteur merged commit e3b8319 into master Feb 2, 2015
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. and removed c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Feb 2, 2015
@tsteur tsteur added this to the Piwik 2.11.0 milestone Feb 2, 2015
@tsteur tsteur self-assigned this Feb 2, 2015
@tsteur tsteur deleted the uiTestClass branch February 2, 2015 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsteur tsteur

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur