Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monolog plugin #7118

Merged
merged 1 commit into from Feb 11, 2015
Merged

Monolog plugin #7118

merged 1 commit into from Feb 11, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Feb 1, 2015

I have moved all the Monolog extensions and the container configuration of Monolog into a new Monolog plugin. I had to bump the version to have the plugin registered in the config (if there's a simpler solution let me know).

This is an example of a plugin containing a configuration file (see #7117).

The idea of this plugin is that Piwik Core (and other plugins) only depends on Psr\Log\LoggerInterface and can work without Monolog, so Monolog stuff shouldn't be in Piwik Core. It also simplifies a lot the global container config.

This PR is based on #7117 which explains why the diff includes those changes

@tsteur
Copy link
Member

tsteur commented Feb 3, 2015

Looks good to me

@mnapoli mnapoli added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 4, 2015
@mnapoli mnapoli self-assigned this Feb 4, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented Feb 4, 2015

On hold because of changes needed in #7117

@mnapoli mnapoli force-pushed the log-plugin branch 3 times, most recently from 78db7d5 to c3267a0 Compare February 5, 2015 01:22
@mnapoli
Copy link
Contributor Author

mnapoli commented Feb 5, 2015

UI tests failed because of the new plugin (the plugin page now reports the Monolog plugin).

Other than that, good to merge.

@mnapoli mnapoli removed their assignment Feb 5, 2015
@mnapoli mnapoli added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Feb 5, 2015
@mattab
Copy link
Member

mattab commented Feb 9, 2015

Looks good to me
@mnapoli feel free to rebase & merge after #7117

@mattab mattab added this to the Piwik 2.11.0 milestone Feb 9, 2015
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 9, 2015
@mattab
Copy link
Member

mattab commented Feb 11, 2015

fyi need rebase and good to merge

mnapoli added a commit that referenced this pull request Feb 11, 2015
@mnapoli mnapoli merged commit 8343126 into master Feb 11, 2015
@mnapoli mnapoli deleted the log-plugin branch February 11, 2015 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants