New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monolog plugin #7118
Merged
Merged
Monolog plugin #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me |
mnapoli
added
the
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
label
Feb 4, 2015
On hold because of changes needed in #7117 |
mnapoli
force-pushed
the
log-plugin
branch
3 times, most recently
from
February 5, 2015 01:22
78db7d5
to
c3267a0
Compare
UI tests failed because of the new plugin (the plugin page now reports the Other than that, good to merge. |
mnapoli
added
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
c: New plugin
For features that probably will not be added to Matomo, but could be implemented as plugins.
and removed
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
labels
Feb 5, 2015
mattab
added
the
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
label
Feb 9, 2015
fyi need rebase and good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: New plugin
For features that probably will not be added to Matomo, but could be implemented as plugins.
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Pull Request WIP
Indicates the current pull request is still work in progress and not ready yet for a review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have moved all the Monolog extensions and the container configuration of Monolog into a new Monolog plugin. I had to bump the version to have the plugin registered in the config (if there's a simpler solution let me know).
This is an example of a plugin containing a configuration file (see #7117).
The idea of this plugin is that Piwik Core (and other plugins) only depends on
Psr\Log\LoggerInterface
and can work without Monolog, so Monolog stuff shouldn't be in Piwik Core. It also simplifies a lot the global container config.This PR is based on #7117 which explains why the diff includes those changes