New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usernames should allow German umlauts characters #7114
Comments
FYI: If we change it, we need to check all usages of the login for security etc. It might be used somewhere and not proper escaped as one was assuming it contains only |
@tsteur is it possible to check if it's a character or a special char?
|
If this is just about umlauts as a temporary fix we should be able to just add |
@tsteur depends on the charset...used it somewhere for LDAP regex, but also didnt contain all wanted chars :-) Seems to be a bit complicated.... |
if we can fix this in core by adding umlauts to the regex then maybe we should just do this for now? |
We should just still leave the issue open or create a follow up issue to also fix this for other letters. People will most likely have this problem again very soon |
Is there any workaround for this? |
@ChristianGfK try this workaround (NOT tested) Replace this line https://github.com/piwik/piwik/blob/master/core/Piwik.php#L592 && (preg_match('/^[A-Za-zÄäÖöÜüß0-9_.@+-]*$/D', $userLogin) > 0)) |
Thanks @ThaDafinser, I'll have a look at doing that when I take the 2.16 plunge later. :-) |
as we have so many German users, let's do the quick fix of allowing german characters in 2.16.x 👍 |
Caused by line https://github.com/piwik/piwik/blob/master/core/Piwik.php#L601. The regex prevents usernames from having special characters. I'm not sure what exactly the point of this is, why not allow all characters in a login handle?
Anyway, this is an issue for at least one user using LoginLdap: matomo-org/plugin-LoginLdap#86
The text was updated successfully, but these errors were encountered: