Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to specify an alternate whois provider - SEO plugin #7107

Closed
tsteur opened this issue Jan 29, 2015 · 0 comments
Closed

Provide a way to specify an alternate whois provider - SEO plugin #7107

tsteur opened this issue Jan 29, 2015 · 0 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Piwik 2.11.0

Comments

@tsteur
Copy link
Member

tsteur commented Jan 29, 2015

Requested by a user in #7103

We could post an event in SEO.getRank https://github.com/piwik/piwik/blob/2.11.0-b3/plugins/SEO/API.php#L41 to initialize the $data array. We would not overwrite any existing keys / ranks afterwards.

We could alternatively or on top add plugin settings to disable/enable each provider. Eg if someone is not interested in whois or Alexa or Google you would simply uncheck it (SystemSetting I reckon)
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 29, 2015
@tsteur tsteur added this to the Mid term milestone Jan 29, 2015
mnapoli added a commit that referenced this issue Feb 10, 2015
@mnapoli
#7153 #4172 #7107 Refactored the SEO plugin to make it more extensibl…
9d4bbce 
…e and error-proof

- SEO metrics are returned by `MetricsProvider` implementations
- a new event `SEO.getMetricsProviders` allows other plugins to register `MetricsProvider`
- errors while connecting to a 3rd party service are now logged as warning, and shown in the widget as `-` instead of the values.
@mnapoli mnapoli mentioned this issue Feb 11, 2015
Merged
@mattab mattab modified the milestones: Piwik 2.11.0, Mid term Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
2 participants
@tsteur @mattab