Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whois.com rate limit #7103

Closed
mrjoops opened this issue Jan 29, 2015 · 3 comments
Closed

whois.com rate limit #7103

mrjoops opened this issue Jan 29, 2015 · 3 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Piwik 2.11.0

Comments

@mrjoops
Copy link

mrjoops commented Jan 29, 2015

As you may know, many free webservices are rate-limited, and whois.com is no different.
Actually the free limit is set to 100 requests a day.
In Piwik, when I look at my dashboard and then click on parameters, I already sent 3 requests to whois.com.
Here are some ideas for future enhancements:

  • cache responses in database ;
  • provide a way to specify an alternate whois provider.
@tsteur
Copy link
Member

tsteur commented Jan 29, 2015

Let's cache the SEO.getRank data using our Lazy cache: https://github.com/piwik/piwik/blob/2.11.0-b3/plugins/SEO/API.php#L41

There shouldn't be many changes in the output so we could cache it for eg 6 hours per URL to not ending up in exceeding the limit if users manage multiple sites

@tsteur tsteur added Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Bug For errors / faults / flaws / inconsistencies etc. and removed Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Jan 29, 2015
@tsteur tsteur added this to the Piwik 2.11.0 milestone Jan 29, 2015
@tsteur tsteur self-assigned this Jan 29, 2015
@tsteur
Copy link
Member

tsteur commented Jan 29, 2015

provide a way to specify an alternate whois provider

This could be probably done via a plugin if someone wants to do it. Maybe create another issue for it?

tsteur added a commit that referenced this issue Jan 29, 2015
@tsteur
refs #7103 cache SEO.getRank API output per URL for 6 hours to avoid …
4b529bb 
…exceeding rate limits
This was referenced Jan 29, 2015
Closed
Closed
@tsteur
Copy link
Member

tsteur commented Jan 29, 2015

Rank will be cached for 6 hours now and I created another issue re alternate whois provider

@tsteur tsteur closed this as completed Jan 29, 2015
@mattab mattab mentioned this issue Feb 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
2 participants
@tsteur @mrjoops