Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new config parameter allowing to disable complete range archives p... #7080

Closed

Conversation

mgazdzik
Copy link
Contributor

...urging in case they should be persisted. refs #7079

…s purging in case they should be persisted
@tsteur
Copy link
Member

tsteur commented Jan 27, 2015

Be aware that it would never delete any date range archive. To make it more useful for more people maybe it makes sense to define something like purge_date_range_archives_after_X_days = 1 . Name would be to defined. We would pass this value to the method and instead of generating the date "yesterday" hardcoded we would go back by the number of given days which is by default 1 (for yesterday). To disable it completely as you want to we could use the value -1 or 0 or whatever. Or one simply specifies a very high value eg 99999.

BTW: You also want to rebase master I reckon. That version of Piwik is about a year old.

@mgazdzik mgazdzik closed this Jan 28, 2015
@mgazdzik mgazdzik deleted the preventCustomRangePurging branch January 28, 2015 08:21
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Feb 7, 2015
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants