Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Admin/User menu items cannot be clicked when item is active #7064

Closed
tsteur opened this issue Jan 22, 2015 · 1 comment
Closed

Some Admin/User menu items cannot be clicked when item is active #7064

tsteur opened this issue Jan 22, 2015 · 1 comment
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
Piwik 2.11.0

Comments

@tsteur
Copy link
Member

tsteur commented Jan 22, 2015

Reproducable on Chrome 39 and Firefox 35 on Mac. Probably other browsers as well.

When clicking on some menu items, the page is not reloaded when the menu item is active eg.

Personal => Email reports, Personal => Settings, Administration => Users

Whereas on other menu items it works, eg

Personal => Custom Alerts, Administration => Plugins

I debugged this behaviour using Chrome but couldn't find the problem so far.

To reproduce eg. go to "Administration => Pages", now click this menu item again and page reloads which is expected behavior. Now go to "Administration => Users" and click the menu item again afterwards. Nothing happens but it should reload the page.
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Jan 22, 2015
@tsteur tsteur added this to the Piwik 2.11.0 milestone Jan 22, 2015
@tsteur
Copy link
Member Author

tsteur commented Jan 22, 2015

After further JS debugging I can see a pattern that the link won't work if AngularJS is used on that page.
At https://github.com/angular/angular.js/blob/aa798f123658cb78b5581513d26577016195cafe/src/ng/location.js#L869

@tsteur tsteur closed this as completed in 67ef6f9 Jan 23, 2015
@tsteur tsteur self-assigned this Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
1 participant
@tsteur