Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibibility to add more metrics to actions plugin #7041

Merged
merged 5 commits into from Jan 20, 2015
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 16, 2015

refs #5248

Extended can be currently getPageUrls, getPageTitles

}

return $prettyBytes;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method already exists as Formatter::getPrettySizeFromBytes, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, I searched for it but didn't find the existing one. Will use the existing one. Might change the existing one to remove the space before the unit and use 'GB' instead of 'G' just to be clearer

@tsteur tsteur self-assigned this Jan 20, 2015
@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. and removed Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Jan 20, 2015
@tsteur tsteur added this to the Piwik 2.11.0 milestone Jan 20, 2015
tsteur added a commit that referenced this pull request Jan 20, 2015
added possibibility to add more metrics to actions plugin
@tsteur tsteur merged commit 9cda39e into master Jan 20, 2015
@tsteur tsteur deleted the 5248 branch January 20, 2015 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants