Refactored Twig templates using a single base layout #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also should affect #7036
mnapoli
added
the
Enhancement
|
No comments, merging. |
mnapoli
added a commit
that referenced
this pull request
Jan 21, 2015
Refactored Twig templates using a single base layout
|
The login does no longer work now see failing UI tests, I will investigate if I can find the cause |
tsteur
added a commit
that referenced
this pull request
Jan 21, 2015
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several base layout files:
Those had a lot of similarities of course, and few discrepancies which could create bugs like #7036 or inconsistent stuff (e.g. missing favicon, missing description tag, CSS included twice in login, angularjs not initialized, …).
I added a new
layout.twigfile that defines the base HTML layout for pages. Other layouts extend it by redefining Twig blocks.Also fixes #7036