Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Skip to content" feature when user presses tab key (accessibility) #7025

Merged
merged 30 commits into from Jan 15, 2015

Conversation

flodrwho
Copy link

  • item 1 Accessibility: Skip to main content #7004
    this adds a link in the head which only appears when tabed over, this sends the user down the page to the main content where another corresponding link is. then is changed the css so it would be off screen when not focused on. and it will be the first thing focused on when the tab key is pressed.

flora edwards added 9 commits January 14, 2015 14:12
…the widgits on the dashboard to h3 from span without changing what it looked like.
…arker for enough contrast for users with eyesight difficulties.
…when not in focus and in the top middle of the screen when someone tabs onto it.
…ill go when they have clicked the skip to content link
@mattab
Copy link
Member

mattab commented Jan 15, 2015

Also:

  • Blue color was set darker for more contrast
  • Alt text was added to graph to explain they are graph

flora edwards and others added 20 commits January 15, 2015 15:40
…indefinitely on an HTTP request

More particularly, this resulted in the installation hanging at the second step (system check) when using PHP's built-in webserver.
…files in W3C extended log file format can be imported from stdin w/o a '#Fields:' line being present.
…the widgits on the dashboard to h3 from span without changing what it looked like.
…arker for enough contrast for users with eyesight difficulties.
…when not in focus and in the top middle of the screen when someone tabs onto it.
…ill go when they have clicked the skip to content link
mattab pushed a commit that referenced this pull request Jan 15, 2015
@mattab mattab merged commit 1563733 into matomo-org:master Jan 15, 2015
@mattab
Copy link
Member

mattab commented Jan 15, 2015

Great changes, thanks @flodrwho ! 👍

@mattab mattab changed the title skip to content Add "Skip to content" feature when user presses tab key Jan 15, 2015
@mattab mattab changed the title Add "Skip to content" feature when user presses tab key Add "Skip to content" feature when user presses tab key (accessibility) Feb 16, 2015
@mattab mattab added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Feb 16, 2015
@jdeyla
Copy link

jdeyla commented Mar 13, 2015

Hi,
I'm testing on demo site: https://demo.piwik.org

SKIP CONTENT link is quite good but has some problems, when using just the keyboard (link text appears, but under the menù)
I suggest to use the same approach of http://webaim.org/ (just TAB on keyboard)

I also suggest to use their script in order to highlight text or link or buttons, which is another problem Piwik has.

@mnapoli
Copy link
Contributor

mnapoli commented Mar 14, 2015

@jdeyla I don't understand what the problem is? To me it works perfectly fine on the demo, just like the site you linked.

@mattab
Copy link
Member

mattab commented Mar 16, 2015

I also suggest to use their script in order to highlight text or link or buttons, which is another problem Piwik has.

Hi there, could you create an issue for this problem and maybe show a screenshot showing the problem?

@jdeyla
Copy link

jdeyla commented Mar 16, 2015

Hi I didn't create an issue beacuse this issue was the right one in my opinion. I attach a screenshot taken with Firefox 36.0.1 Win XP, tabbing on skip content link
piwik1

@mattab
Copy link
Member

mattab commented Mar 16, 2015

Hi @jdeyla thanks for report. tracked in #7451

@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants